Comments on: Swing garbage collection – problems with the observer pattern http://www.objectdefinitions.com/odblog/2007/swing-garbage-collection-problems-with-the-observer-pattern/ Software Development - random theories, code snippits and opinions Tue, 18 Oct 2011 23:30:17 +0000 http://wordpress.org/?v=2.9.2 hourly 1 By: Nick http://www.objectdefinitions.com/odblog/2007/swing-garbage-collection-problems-with-the-observer-pattern/comment-page-1/#comment-2017 Nick Mon, 23 Feb 2009 13:54:28 +0000 http://www.objectdefinitions.com/odblog/2007/swing-garbage-collection-problems-with-the-observer-pattern/#comment-2017 Bez, You were spot on there, how did I let that one slip through? Thanks for finding that and pointing it out, I have revised the example thanks Nick Bez,

You were spot on there, how did I let that one slip through?
Thanks for finding that and pointing it out, I have revised the example

thanks

Nick

]]> By: bez http://www.objectdefinitions.com/odblog/2007/swing-garbage-collection-problems-with-the-observer-pattern/comment-page-1/#comment-2016 bez Mon, 23 Feb 2009 13:34:50 +0000 http://www.objectdefinitions.com/odblog/2007/swing-garbage-collection-problems-with-the-observer-pattern/#comment-2016 There is a slight bug in your implementation of WeakRefActionListener.actionPerformed(), in that the reference may be nulled in between the two calls to get(). To fix it, hold a local strong reference from a single call: public void actionPerformed(ActionEvent e) { ActionListener delegate = actionListenerDelegate.get(); if (delegate != null) { delegate.actionPerformed(e); } } There is a slight bug in your implementation of WeakRefActionListener.actionPerformed(), in that the reference may be nulled in between the two calls to get().

To fix it, hold a local strong reference from a single call:

public void actionPerformed(ActionEvent e)
{
ActionListener delegate = actionListenerDelegate.get();
if (delegate != null)
{
delegate.actionPerformed(e);
}
}

]]>